diff options
| author | Johann-S <[email protected]> | 2019-07-28 15:24:46 +0200 |
|---|---|---|
| committer | Johann-S <[email protected]> | 2019-07-29 11:34:12 +0200 |
| commit | dcba52677556bedb04a07825c2023e0beeea6f1e (patch) | |
| tree | ddf5bbf334408536c609f2ded245e119c1a9de17 /js/src/tab | |
| parent | 144220f0c5777e07fb1832324d52a590bec363e2 (diff) | |
| download | bootstrap-dcba52677556bedb04a07825c2023e0beeea6f1e.tar.xz bootstrap-dcba52677556bedb04a07825c2023e0beeea6f1e.zip | |
remove underscore for static methods
Diffstat (limited to 'js/src/tab')
| -rw-r--r-- | js/src/tab/tab.js | 8 | ||||
| -rw-r--r-- | js/src/tab/tab.spec.js | 26 |
2 files changed, 17 insertions, 17 deletions
diff --git a/js/src/tab/tab.js b/js/src/tab/tab.js index c9f4869ef..2d4b8e30c 100644 --- a/js/src/tab/tab.js +++ b/js/src/tab/tab.js @@ -210,7 +210,7 @@ class Tab { // Static - static _jQueryInterface(config) { + static jQueryInterface(config) { return this.each(function () { const data = Data.getData(this, DATA_KEY) || new Tab(this) @@ -224,7 +224,7 @@ class Tab { }) } - static _getInstance(element) { + static getInstance(element) { return Data.getData(element, DATA_KEY) } } @@ -251,11 +251,11 @@ EventHandler.on(document, Event.CLICK_DATA_API, Selector.DATA_TOGGLE, function ( /* istanbul ignore if */ if (typeof $ !== 'undefined') { const JQUERY_NO_CONFLICT = $.fn[NAME] - $.fn[NAME] = Tab._jQueryInterface + $.fn[NAME] = Tab.jQueryInterface $.fn[NAME].Constructor = Tab $.fn[NAME].noConflict = () => { $.fn[NAME] = JQUERY_NO_CONFLICT - return Tab._jQueryInterface + return Tab.jQueryInterface } } diff --git a/js/src/tab/tab.spec.js b/js/src/tab/tab.spec.js index 3fae366d1..9530f3def 100644 --- a/js/src/tab/tab.spec.js +++ b/js/src/tab/tab.spec.js @@ -329,26 +329,26 @@ describe('Tab', () => { const el = fixtureEl.querySelector('div') const tab = new Tab(fixtureEl.querySelector('div')) - expect(Tab._getInstance(el)).not.toBeNull() + expect(Tab.getInstance(el)).not.toBeNull() tab.dispose() - expect(Tab._getInstance(el)).toBeNull() + expect(Tab.getInstance(el)).toBeNull() }) }) - describe('_jQueryInterface', () => { + describe('jQueryInterface', () => { it('should create a tab', () => { fixtureEl.innerHTML = '<div></div>' const div = fixtureEl.querySelector('div') - jQueryMock.fn.tab = Tab._jQueryInterface + jQueryMock.fn.tab = Tab.jQueryInterface jQueryMock.elements = [div] jQueryMock.fn.tab.call(jQueryMock) - expect(Tab._getInstance(div)).toBeDefined() + expect(Tab.getInstance(div)).toBeDefined() }) it('should not re create a tab', () => { @@ -357,12 +357,12 @@ describe('Tab', () => { const div = fixtureEl.querySelector('div') const tab = new Tab(div) - jQueryMock.fn.tab = Tab._jQueryInterface + jQueryMock.fn.tab = Tab.jQueryInterface jQueryMock.elements = [div] jQueryMock.fn.tab.call(jQueryMock) - expect(Tab._getInstance(div)).toEqual(tab) + expect(Tab.getInstance(div)).toEqual(tab) }) it('should call a tab method', () => { @@ -373,12 +373,12 @@ describe('Tab', () => { spyOn(tab, 'show') - jQueryMock.fn.tab = Tab._jQueryInterface + jQueryMock.fn.tab = Tab.jQueryInterface jQueryMock.elements = [div] jQueryMock.fn.tab.call(jQueryMock, 'show') - expect(Tab._getInstance(div)).toEqual(tab) + expect(Tab.getInstance(div)).toEqual(tab) expect(tab.show).toHaveBeenCalled() }) @@ -388,7 +388,7 @@ describe('Tab', () => { const div = fixtureEl.querySelector('div') const action = 'undefinedMethod' - jQueryMock.fn.tab = Tab._jQueryInterface + jQueryMock.fn.tab = Tab.jQueryInterface jQueryMock.elements = [div] try { @@ -399,9 +399,9 @@ describe('Tab', () => { }) }) - describe('_getInstance', () => { + describe('getInstance', () => { it('should return null if there is no instance', () => { - expect(Tab._getInstance(fixtureEl)).toEqual(null) + expect(Tab.getInstance(fixtureEl)).toEqual(null) }) it('should return this instance', () => { @@ -410,7 +410,7 @@ describe('Tab', () => { const divEl = fixtureEl.querySelector('div') const tab = new Tab(divEl) - expect(Tab._getInstance(divEl)).toEqual(tab) + expect(Tab.getInstance(divEl)).toEqual(tab) }) }) |
