diff options
| author | Patrick H. Lauke <[email protected]> | 2017-04-12 18:50:31 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2017-04-12 18:50:31 +0100 |
| commit | 1f80f61677da40944f5af043722aedeebd3b71c3 (patch) | |
| tree | ac4051a21634e21f77b308a36436d36a1af20069 /js/src | |
| parent | 29460b2005cde9ff807dc2c846fb95f150ffa872 (diff) | |
| parent | 3275ca4b30383390d3475beb8c4f43343ab31f5c (diff) | |
| download | bootstrap-1f80f61677da40944f5af043722aedeebd3b71c3.tar.xz bootstrap-1f80f61677da40944f5af043722aedeebd3b71c3.zip | |
Reword "mobile" to "touch-enabled"
...as touch is not exclusive to "mobile" anymore nowadays. also explicitly clarifies this is a fix for iOS, and that it impacts touch laptops etc as well. lastly, renames the variable from "dropdown" to "backdrop" for clarity/consistency
Diffstat (limited to 'js/src')
| -rw-r--r-- | js/src/dropdown.js | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/js/src/dropdown.js b/js/src/dropdown.js index 644273a0a..96b7c8773 100644 --- a/js/src/dropdown.js +++ b/js/src/dropdown.js @@ -112,11 +112,12 @@ const Dropdown = (($) => { if ('ontouchstart' in document.documentElement && !$(parent).closest(Selector.NAVBAR_NAV).length) { - // if mobile we use a backdrop because click events don't delegate - const dropdown = document.createElement('div') - dropdown.className = ClassName.BACKDROP - $(dropdown).insertBefore(this) - $(dropdown).on('click', Dropdown._clearMenus) + // if touch-enabled device we use a backdrop because click events + // don't delegate on iOS - see https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html + const backdrop = document.createElement('div') + backdrop.className = ClassName.BACKDROP + $(backdrop).insertBefore(this) + $(backdrop).on('click', Dropdown._clearMenus) } this.focus() |