aboutsummaryrefslogtreecommitdiff
path: root/js/src
diff options
context:
space:
mode:
authorPierre-Denis Vanduynslager <[email protected]>2017-02-08 18:51:50 -0500
committerPierre-Denis Vanduynslager <[email protected]>2017-02-08 18:51:50 -0500
commit4ab576a41941b720e2f6fa77724203f66a1d3a17 (patch)
tree82a26f84399cc8a789627ac18afcabcfc9a6d1d5 /js/src
parent403f55fba976908cd1fd9dfd8ea4a98d035daaf2 (diff)
downloadbootstrap-4ab576a41941b720e2f6fa77724203f66a1d3a17.tar.xz
bootstrap-4ab576a41941b720e2f6fa77724203f66a1d3a17.zip
Fixes #21941
Diffstat (limited to 'js/src')
-rw-r--r--js/src/dropdown.js14
1 files changed, 8 insertions, 6 deletions
diff --git a/js/src/dropdown.js b/js/src/dropdown.js
index 5c204f054..1e85c2530 100644
--- a/js/src/dropdown.js
+++ b/js/src/dropdown.js
@@ -25,6 +25,7 @@ const Dropdown = (($) => {
const JQUERY_NO_CONFLICT = $.fn[NAME]
const ESCAPE_KEYCODE = 27 // KeyboardEvent.which value for Escape (Esc) key
const SPACE_KEYCODE = 32 // KeyboardEvent.which value for space key
+ const TAB_KEYCODE = 9 // KeyboardEvent.which value for tab key
const ARROW_UP_KEYCODE = 38 // KeyboardEvent.which value for up arrow key
const ARROW_DOWN_KEYCODE = 40 // KeyboardEvent.which value for down arrow key
const RIGHT_MOUSE_BUTTON_WHICH = 3 // MouseEvent.which value for the right button (assuming a right-handed mouse)
@@ -37,8 +38,8 @@ const Dropdown = (($) => {
SHOWN : `shown${EVENT_KEY}`,
CLICK : `click${EVENT_KEY}`,
CLICK_DATA_API : `click${EVENT_KEY}${DATA_API_KEY}`,
- FOCUSIN_DATA_API : `focusin${EVENT_KEY}${DATA_API_KEY}`,
- KEYDOWN_DATA_API : `keydown${EVENT_KEY}${DATA_API_KEY}`
+ KEYDOWN_DATA_API : `keydown${EVENT_KEY}${DATA_API_KEY}`,
+ KEYUP_DATA_API : `keyup${EVENT_KEY}${DATA_API_KEY}`
}
const ClassName = {
@@ -160,7 +161,8 @@ const Dropdown = (($) => {
}
static _clearMenus(event) {
- if (event && event.which === RIGHT_MOUSE_BUTTON_WHICH) {
+ if (event && (event.which === RIGHT_MOUSE_BUTTON_WHICH ||
+ event.type === 'keyup' && event.which !== TAB_KEYCODE)) {
return
}
@@ -182,7 +184,7 @@ const Dropdown = (($) => {
}
if (event && (event.type === 'click' &&
- /input|textarea/i.test(event.target.tagName) || event.type === 'focusin')
+ /input|textarea/i.test(event.target.tagName) || event.type === 'keyup' && event.which === TAB_KEYCODE)
&& $.contains(parent, event.target)) {
continue
}
@@ -213,7 +215,7 @@ const Dropdown = (($) => {
}
static _dataApiKeydownHandler(event) {
- if (!REGEXP_KEYDOWN.test(event.which) && /button/i.test(event.target.tagName) && event.which === SPACE_KEYCODE ||
+ if (!REGEXP_KEYDOWN.test(event.which) || /button/i.test(event.target.tagName) && event.which === SPACE_KEYCODE ||
/input|textarea/i.test(event.target.tagName)) {
return
}
@@ -275,7 +277,7 @@ const Dropdown = (($) => {
$(document)
.on(Event.KEYDOWN_DATA_API, Selector.DATA_TOGGLE, Dropdown._dataApiKeydownHandler)
.on(Event.KEYDOWN_DATA_API, Selector.MENU, Dropdown._dataApiKeydownHandler)
- .on(`${Event.CLICK_DATA_API} ${Event.FOCUSIN_DATA_API}`, Dropdown._clearMenus)
+ .on(`${Event.CLICK_DATA_API} ${Event.KEYUP_DATA_API}`, Dropdown._clearMenus)
.on(Event.CLICK_DATA_API, Selector.DATA_TOGGLE, Dropdown.prototype.toggle)
.on(Event.CLICK_DATA_API, Selector.FORM_CHILD, (e) => {
e.stopPropagation()