diff options
| author | Ben Lertlumprasertkul <[email protected]> | 2021-05-11 06:45:57 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-05-11 08:45:57 +0300 |
| commit | 052def456845c2147e4e6c99d17bba12fcbee34c (patch) | |
| tree | 9f23d9f09941c43fd519bde2498da808a8764635 /js/tests/unit/scrollspy.spec.js | |
| parent | 9c3ab6557ec89ae11cc27da1b4680b3e69381edf (diff) | |
| download | bootstrap-052def456845c2147e4e6c99d17bba12fcbee34c.tar.xz bootstrap-052def456845c2147e4e6c99d17bba12fcbee34c.zip | |
Remove potential false positive assertions (#33288)
* Remove potential false positive assertions
querySelector() returns null but
expect(document.querySelector('...')).toBeDefined()
tests that the value is not undefined
* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests
* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call
* convert more cases to not.toBeNull assertions
Co-authored-by: XhmikosR <[email protected]>
Diffstat (limited to 'js/tests/unit/scrollspy.spec.js')
| -rw-r--r-- | js/tests/unit/scrollspy.spec.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/js/tests/unit/scrollspy.spec.js b/js/tests/unit/scrollspy.spec.js index c4130a1aa..6b2a13430 100644 --- a/js/tests/unit/scrollspy.spec.js +++ b/js/tests/unit/scrollspy.spec.js @@ -602,7 +602,7 @@ describe('ScrollSpy', () => { jQueryMock.fn.scrollspy.call(jQueryMock) - expect(ScrollSpy.getInstance(div)).toBeDefined() + expect(ScrollSpy.getInstance(div)).not.toBeNull() }) it('should create a scrollspy with given config', () => { @@ -618,7 +618,7 @@ describe('ScrollSpy', () => { expect(ScrollSpy.prototype.constructor).not.toHaveBeenCalledWith(div, { offset: 15 }) const scrollspy = ScrollSpy.getInstance(div) - expect(scrollspy).toBeDefined() + expect(scrollspy).not.toBeNull() expect(scrollspy._config.offset).toBe(15) }) |