diff options
| author | Pierre Vanduynslager <[email protected]> | 2017-03-28 17:43:16 -0400 |
|---|---|---|
| committer | Johann-S <[email protected]> | 2017-03-28 23:43:15 +0200 |
| commit | 48c5efa4c3c439d8720b8475ec3e372c6974a12a (patch) | |
| tree | 927c262f444f4aaeb0f598cf35ab7b1b385ae76a /js/tests/visual | |
| parent | ce0e2f8e76dade4b6ec9d6eb541c6988739f0653 (diff) | |
| download | bootstrap-48c5efa4c3c439d8720b8475ec3e372c6974a12a.tar.xz bootstrap-48c5efa4c3c439d8720b8475ec3e372c6974a12a.zip | |
Fix JS components console error "Error: <Component> is transitioning"
Diffstat (limited to 'js/tests/visual')
| -rw-r--r-- | js/tests/visual/carousel.html | 24 | ||||
| -rw-r--r-- | js/tests/visual/collapse.html | 25 | ||||
| -rw-r--r-- | js/tests/visual/modal.html | 21 | ||||
| -rw-r--r-- | js/tests/visual/tooltip.html | 19 |
4 files changed, 2 insertions, 87 deletions
diff --git a/js/tests/visual/carousel.html b/js/tests/visual/carousel.html index b02d28a05..ad249d874 100644 --- a/js/tests/visual/carousel.html +++ b/js/tests/visual/carousel.html @@ -45,31 +45,11 @@ <script src="../../dist/carousel.js"></script> <script> - // Should throw an error because carousel is in transition - function testCarouselTransitionError() { - var err = false - var $carousel = $('#carousel-example-generic') - $carousel.on('slid.bs.carousel', function () { - $carousel.off('slid.bs.carousel') - if (!err) { - alert('No error thrown for : testCarouselTransitionError') - } - }) - try { - $carousel.carousel('next').carousel('prev') - } - catch (e) { - err = true - console.error(e.message) - } - } - - $(function () { + $(function() { // Test to show that the carousel doesn't slide when the current tab isn't visible - $('#carousel-example-generic').on('slid.bs.carousel', function (event) { + $('#carousel-example-generic').on('slid.bs.carousel', function(event) { console.log('slid at ', event.timeStamp) }) - testCarouselTransitionError() }) </script> </body> diff --git a/js/tests/visual/collapse.html b/js/tests/visual/collapse.html index 3eb585b7b..fe45c1804 100644 --- a/js/tests/visual/collapse.html +++ b/js/tests/visual/collapse.html @@ -60,30 +60,5 @@ <script src="../../../docs/assets/js/vendor/jquery-slim.min.js"></script> <script src="../../dist/util.js"></script> <script src="../../dist/collapse.js"></script> - <script> - // JavaScript Test - $(function () { - testCollapseTransitionError() - }); - - // Should throw an error because carousel is in transition - function testCollapseTransitionError() { - var err = false - $('#collapseOne').on('hidden.bs.collapse', function (e) { - $(this).off('hidden.bs.collapse') - if (!err) { - alert('No error thrown for : testCollapseTransitionError') - } - }) - - try { - $('#collapseOne').collapse('hide').collapse('show') - } - catch (e) { - err = true - console.error(e.message) - } - } - </script> </body> </html> diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index d971a45c7..e999514f7 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -187,26 +187,6 @@ } } - // Should throw an error because modal is in transition - function testModalTransitionError() { - var err = false - // Close #myModal - $('#myModal').on('shown.bs.modal', function () { - $('#myModal').modal('hide').off('shown.bs.modal') - if (!err) { - alert('No error thrown for : testModalTransitionError') - } - }) - - try { - $('#myModal').modal('show').modal('hide') - } - catch (e) { - err = true - console.error(e.message) - } - } - $(function () { $('[data-toggle="popover"]').popover() $('[data-toggle="tooltip"]').tooltip() @@ -219,7 +199,6 @@ $('#firefoxModal').on('focus', reportFirefoxTestResult.bind(false)) $('#ff-bug-input').on('focus', reportFirefoxTestResult.bind(true)) }) - testModalTransitionError() }) </script> </body> diff --git a/js/tests/visual/tooltip.html b/js/tests/visual/tooltip.html index ada6d8b79..f447a533b 100644 --- a/js/tests/visual/tooltip.html +++ b/js/tests/visual/tooltip.html @@ -41,26 +41,7 @@ <script> $(function () { $('[data-toggle="tooltip"]').tooltip() - testTooltipTransitionError() }) - - // Should throw an error because tooltip is in transition - function testTooltipTransitionError() { - var err = false - $('#btnOne').on('shown.bs.tooltip', function () { - $('#btnOne').tooltip('hide').off('shown.bs.tooltip') - if (!err) { - alert('No error thrown for : testTooltipTransitionError') - } - }) - try { - $('#btnOne').tooltip('show').tooltip('hide') - } - catch (e) { - err = true - console.error(e.message) - } - } </script> </body> </html> |
