diff options
| author | Geremia Taglialatela <[email protected]> | 2017-04-12 16:06:52 +0200 |
|---|---|---|
| committer | Mark Otto <[email protected]> | 2017-05-27 15:21:49 -0700 |
| commit | db44e4b311317ef760f8412cc33c84146959b248 (patch) | |
| tree | daf89d9f3d96fab2276ff368ec6969c5681a494e /js/tests/visual | |
| parent | f2829dd6ea10d1af7e451397f7228087cff95b8a (diff) | |
| download | bootstrap-db44e4b311317ef760f8412cc33c84146959b248.tar.xz bootstrap-db44e4b311317ef760f8412cc33c84146959b248.zip | |
Update nav and navbar HTML markup
According to the docs, you just need to apply the `navbar-nav` to an
`<ul>` tag in a list-based navbar. In fact, `navbar-nav` seems to
override all the css properties set by `nav`.
Also, `nav-item` class should be used only for `<li>` tags, or in
conjunction with `<a>` tags to entirely avoid the list-based approach.
This commit removes the redundant `nav` class from `navbar-nav` `<ul>`
tags, moves `nav-item` from `<a>` tags to `<li>` tags and properly
adds `nav-item` class to `<li>` tags where missing.
Refs:
* https://v4-alpha.getbootstrap.com/components/navs/
* https://v4-alpha.getbootstrap.com/components/navbar/#nav
Diffstat (limited to 'js/tests/visual')
| -rw-r--r-- | js/tests/visual/modal.html | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index 90b814e67..def62b031 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -17,7 +17,7 @@ <button class="navbar-toggler hidden-lg-up" type="button" data-toggle="collapse" data-target="#navbarResponsive" aria-controls="navbarResponsive" aria-expanded="false" aria-label="Toggle navigation"></button> <div class="collapse navbar-expand-md" id="navbarResponsive"> <a class="navbar-brand" href="#">This shouldn't jump!</a> - <ul class="nav navbar-nav"> + <ul class="navbar-nav"> <li class="nav-item active"> <a class="nav-link" href="#">Home <span class="sr-only">(current)</span></a> </li> |