diff options
| author | Patrick H. Lauke <[email protected]> | 2017-04-17 13:26:46 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2017-04-17 13:26:46 +0100 |
| commit | 6ae5fb12e6c996a6526250e8cb703b007e4213fc (patch) | |
| tree | 620408de7fc859370c7abfad37404d0229439e98 /js/tests | |
| parent | 7ffb61ac5216493bd35a3ff9283f75d58c9ad94f (diff) | |
| download | bootstrap-6ae5fb12e6c996a6526250e8cb703b007e4213fc.tar.xz bootstrap-6ae5fb12e6c996a6526250e8cb703b007e4213fc.zip | |
Fix carousel "hover" behavior on touch-enabled devices
* Add carousel mouse listeners even if touch events enabled
- touch events are enabled not just on "mobile", just also on
touch-enabled desktop/laptop devices; additionally, it's possible to
pair a mouse with traditionally touch-only devices (e.g. Android
phones/tablets); currently, in these situations the carousel WON'T pause
even when using a mouse
* Restart cycle after touchend
as `mouseenter` is fired as part of the touch compatibility events, the
previous change results in carousels which cycle until the user
tapped/interacted with them. after that they stop cycling (as
`mouseleave` is not sent to the carousel after user scrolled/tapped
away).
this fix resets the cycling after `touchend` - essentially returning
to the previous behavior, where on touch the carousel essentially never
pauses, but now with the previous fix it at least pauses correctly for
mouse users on touch-enabled devices.
includes documentation for this new behavior.
Diffstat (limited to 'js/tests')
| -rw-r--r-- | js/tests/unit/carousel.js | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/js/tests/unit/carousel.js b/js/tests/unit/carousel.js index 00b438bb2..894f78ab5 100644 --- a/js/tests/unit/carousel.js +++ b/js/tests/unit/carousel.js @@ -654,29 +654,6 @@ $(function () { assert.strictEqual($template.find('.carousel-item')[0], $template.find('.active')[0], 'first item still active after left arrow press in <textarea>') }) - QUnit.test('should only add mouseenter and mouseleave listeners when not on mobile', function (assert) { - assert.expect(2) - var isMobile = 'ontouchstart' in document.documentElement - var templateHTML = '<div id="myCarousel" class="carousel" data-interval="false" data-pause="hover">' - + '<div class="carousel-inner">' - + '<div id="first" class="carousel-item active">' - + '<img alt="">' - + '</div>' - + '<div id="second" class="carousel-item">' - + '<img alt="">' - + '</div>' - + '<div id="third" class="carousel-item">' - + '<img alt="">' - + '</div>' - + '</div>' - + '</div>' - var $template = $(templateHTML).bootstrapCarousel() - - $.each(['mouseover', 'mouseout'], function (i, type) { - assert.strictEqual(type in $._data($template[0], 'events'), !isMobile, 'does' + (isMobile ? ' not' : '') + ' listen for ' + type + ' events') - }) - }) - QUnit.test('should wrap around from end to start when wrap option is true', function (assert) { assert.expect(3) var carouselHTML = '<div id="carousel-example-generic" class="carousel slide" data-wrap="true">' |
