diff options
| author | Chris Rebert <[email protected]> | 2015-03-25 18:40:44 -0700 |
|---|---|---|
| committer | Chris Rebert <[email protected]> | 2015-03-25 18:40:44 -0700 |
| commit | caa84299ec9cc458265b853e9e925def3eb070d7 (patch) | |
| tree | 175b5c3e1b43c3fcfcd6fe09f00994bc851d1f6c /js/tests | |
| parent | d6714d1383316e449e6766d038bd118039dfd617 (diff) | |
| parent | 6c5e7dfce19425af6e646c8b4578d15f2512d4ad (diff) | |
| download | bootstrap-caa84299ec9cc458265b853e9e925def3eb070d7.tar.xz bootstrap-caa84299ec9cc458265b853e9e925def3eb070d7.zip | |
Merge pull request #16158 from twbs/fix-16020
remove redundant aria-hidden usage from Modals
Diffstat (limited to 'js/tests')
| -rw-r--r-- | js/tests/unit/modal.js | 28 | ||||
| -rw-r--r-- | js/tests/visual/modal.html | 2 |
2 files changed, 1 insertions, 29 deletions
diff --git a/js/tests/unit/modal.js b/js/tests/unit/modal.js index c6e747a3c..3c51c2fe2 100644 --- a/js/tests/unit/modal.js +++ b/js/tests/unit/modal.js @@ -49,18 +49,6 @@ $(function () { .bootstrapModal('show') }) - QUnit.test('should set aria-hidden to false when show method is called', function (assert) { - assert.expect(1) - var done = assert.async() - - $('<div id="modal-test"/>') - .on('shown.bs.modal', function () { - assert.strictEqual($('#modal-test').attr('aria-hidden'), 'false', 'aria-hidden is set to string "false" when modal shown') - done() - }) - .bootstrapModal('show') - }) - QUnit.test('should fire show event', function (assert) { assert.expect(1) var done = assert.async() @@ -106,22 +94,6 @@ $(function () { .bootstrapModal('show') }) - QUnit.test('should set aria-hidden to true when hide is called', function (assert) { - assert.expect(2) - var done = assert.async() - - $('<div id="modal-test"/>') - .on('shown.bs.modal', function () { - assert.strictEqual($('#modal-test').length, 1, 'modal has been inserted into the dom') - $(this).bootstrapModal('hide') - }) - .on('hidden.bs.modal', function () { - assert.strictEqual($('#modal-test').attr('aria-hidden'), 'true', 'aria-hidden is set to string "true" when modal shown') - done() - }) - .bootstrapModal('show') - }) - QUnit.test('should toggle when toggle is called', function (assert) { assert.expect(3) var done = assert.async() diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index fb6dca059..4342f0ce4 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -54,7 +54,7 @@ <h1>Modal <small>Bootstrap Visual Test</small></h1> </div> - <div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> + <div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel"> <div class="modal-dialog"> <div class="modal-content"> |