diff options
| author | Patrick H. Lauke <[email protected]> | 2019-02-19 09:25:37 +0000 |
|---|---|---|
| committer | XhmikosR <[email protected]> | 2019-02-19 11:25:36 +0200 |
| commit | 4b00aa6c4ec9281ad27659babb0e208ab6cdeafa (patch) | |
| tree | 2af08a2efc27ac4e5d20600c81974823efae9dd7 /site/_includes | |
| parent | 68a8af4a36472a448dbd0eb174f80e4b59f931a8 (diff) | |
| download | bootstrap-4b00aa6c4ec9281ad27659babb0e208ab6cdeafa.tar.xz bootstrap-4b00aa6c4ec9281ad27659babb0e208ab6cdeafa.zip | |
Remove incorrect aria-haspopup from dropdown toggles (#28299)
`aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup)
in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies.
in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page
is hidden/inert.
but for now, removing the incorrect attribute is probably the quickest, most immediate fix.
Diffstat (limited to 'site/_includes')
| -rw-r--r-- | site/_includes/docs-navbar.html | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/site/_includes/docs-navbar.html b/site/_includes/docs-navbar.html index a211a0ee0..7714d2e46 100644 --- a/site/_includes/docs-navbar.html +++ b/site/_includes/docs-navbar.html @@ -28,7 +28,7 @@ <ul class="navbar-nav flex-row ml-md-auto d-none d-md-flex"> <li class="nav-item dropdown"> - <a class="nav-item nav-link dropdown-toggle mr-md-2" href="#" id="bd-versions" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"> + <a class="nav-item nav-link dropdown-toggle mr-md-2" href="#" id="bd-versions" data-toggle="dropdown" aria-expanded="false"> v{{ site.docs_version }} </a> <div class="dropdown-menu dropdown-menu-right" aria-labelledby="bd-versions"> |