diff options
| author | Patrick H. Lauke <[email protected]> | 2019-02-19 09:25:37 +0000 |
|---|---|---|
| committer | XhmikosR <[email protected]> | 2019-02-19 11:25:36 +0200 |
| commit | 4b00aa6c4ec9281ad27659babb0e208ab6cdeafa (patch) | |
| tree | 2af08a2efc27ac4e5d20600c81974823efae9dd7 /site/docs/4.3/components/input-group.md | |
| parent | 68a8af4a36472a448dbd0eb174f80e4b59f931a8 (diff) | |
| download | bootstrap-4b00aa6c4ec9281ad27659babb0e208ab6cdeafa.tar.xz bootstrap-4b00aa6c4ec9281ad27659babb0e208ab6cdeafa.zip | |
Remove incorrect aria-haspopup from dropdown toggles (#28299)
`aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup)
in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies.
in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page
is hidden/inert.
but for now, removing the incorrect attribute is probably the quickest, most immediate fix.
Diffstat (limited to 'site/docs/4.3/components/input-group.md')
| -rw-r--r-- | site/docs/4.3/components/input-group.md | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/site/docs/4.3/components/input-group.md b/site/docs/4.3/components/input-group.md index cdbfa794a..1e23e7f99 100644 --- a/site/docs/4.3/components/input-group.md +++ b/site/docs/4.3/components/input-group.md @@ -199,7 +199,7 @@ Multiple add-ons are supported and can be mixed with checkbox and radio input ve {% capture example %} <div class="input-group mb-3"> <div class="input-group-prepend"> - <button class="btn btn-outline-secondary dropdown-toggle" type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">Dropdown</button> + <button class="btn btn-outline-secondary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false">Dropdown</button> <div class="dropdown-menu"> <a class="dropdown-item" href="#">Action</a> <a class="dropdown-item" href="#">Another action</a> @@ -214,7 +214,7 @@ Multiple add-ons are supported and can be mixed with checkbox and radio input ve <div class="input-group"> <input type="text" class="form-control" aria-label="Text input with dropdown button"> <div class="input-group-append"> - <button class="btn btn-outline-secondary dropdown-toggle" type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">Dropdown</button> + <button class="btn btn-outline-secondary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false">Dropdown</button> <div class="dropdown-menu"> <a class="dropdown-item" href="#">Action</a> <a class="dropdown-item" href="#">Another action</a> @@ -233,7 +233,7 @@ Multiple add-ons are supported and can be mixed with checkbox and radio input ve <div class="input-group mb-3"> <div class="input-group-prepend"> <button type="button" class="btn btn-outline-secondary">Action</button> - <button type="button" class="btn btn-outline-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"> + <button type="button" class="btn btn-outline-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-expanded="false"> <span class="sr-only">Toggle Dropdown</span> </button> <div class="dropdown-menu"> @@ -251,7 +251,7 @@ Multiple add-ons are supported and can be mixed with checkbox and radio input ve <input type="text" class="form-control" aria-label="Text input with segmented dropdown button"> <div class="input-group-append"> <button type="button" class="btn btn-outline-secondary">Action</button> - <button type="button" class="btn btn-outline-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"> + <button type="button" class="btn btn-outline-secondary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown" aria-expanded="false"> <span class="sr-only">Toggle Dropdown</span> </button> <div class="dropdown-menu"> |