diff options
| author | ST-DDT <[email protected]> | 2023-10-10 17:07:01 +0200 |
|---|---|---|
| committer | GitHub <[email protected]> | 2023-10-10 17:07:01 +0200 |
| commit | 6cb5aa25f676c7f43fd543e1738e71f54ea5fc6f (patch) | |
| tree | 6c8fb1992bb7709192033b8b901daad3ecd9abb7 | |
| parent | 350dfbf2c57f023a78567da60bf4792ebd1a41f7 (diff) | |
| download | faker-6cb5aa25f676c7f43fd543e1738e71f54ea5fc6f.tar.xz faker-6cb5aa25f676c7f43fd543e1738e71f54ea5fc6f.zip | |
infra(unicorn): explicit-length-check (#2455)
| -rw-r--r-- | .eslintrc.js | 1 | ||||
| -rw-r--r-- | scripts/apidoc/signature.ts | 4 | ||||
| -rw-r--r-- | test/all_functional.spec.ts | 2 | ||||
| -rw-r--r-- | test/vitest-extensions.ts | 2 |
4 files changed, 4 insertions, 5 deletions
diff --git a/.eslintrc.js b/.eslintrc.js index 5625ba35..e137be56 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -52,7 +52,6 @@ module.exports = defineConfig({ 'unicorn/consistent-destructuring': 'off', 'unicorn/consistent-function-scoping': 'off', 'unicorn/escape-case': 'off', - 'unicorn/explicit-length-check': 'off', 'unicorn/filename-case': 'off', 'unicorn/import-style': 'off', 'unicorn/no-array-callback-reference': 'off', diff --git a/scripts/apidoc/signature.ts b/scripts/apidoc/signature.ts index b7c23842..fe11c78d 100644 --- a/scripts/apidoc/signature.ts +++ b/scripts/apidoc/signature.ts @@ -64,7 +64,7 @@ export async function analyzeSignature( // Generate usage section let signatureTypeParametersString = ''; - if (signatureTypeParameters.length !== 0) { + if (signatureTypeParameters.length > 0) { signatureTypeParametersString = `<${signatureTypeParameters.join(', ')}>`; } @@ -207,7 +207,7 @@ async function typeToText(type_?: Type, short = false): Promise<string> { .join(' | '); case 'reference': - if (!type.typeArguments || !type.typeArguments.length) { + if (!type.typeArguments || type.typeArguments.length === 0) { const reflection = type.reflection as DeclarationReflection | undefined; const reflectionType = reflection?.type; if ( diff --git a/test/all_functional.spec.ts b/test/all_functional.spec.ts index 23ed6ccf..0437a239 100644 --- a/test/all_functional.spec.ts +++ b/test/all_functional.spec.ts @@ -70,7 +70,7 @@ function modulesList(): { [module: string]: string[] } { .reduce((result, mod) => { // eslint-disable-next-line @typescript-eslint/no-unsafe-argument const methods = Object.keys(fakerEN[mod]).filter(isMethodOf(mod)); - if (methods.length) { + if (methods.length > 0) { result[mod] = methods; } else { console.log(`Skipping ${mod} - No testable methods`); diff --git a/test/vitest-extensions.ts b/test/vitest-extensions.ts index c241fcf9..e23b9c09 100644 --- a/test/vitest-extensions.ts +++ b/test/vitest-extensions.ts @@ -9,7 +9,7 @@ expect.extend({ const uniqueDuplication = [...new Set(duplications)]; return { - pass: uniqueDuplication.length !== 0, + pass: uniqueDuplication.length > 0, message: () => isNot ? `Duplicated values are [${uniqueDuplication.join(', ')}]` |