refactor(string): remove arbitrary limit from sample (#2497)

3 files changed, 1 insertions, 18 deletions

diff --git a/src/modules/string/index.ts b/src/modules/string/index.ts
index 7c159a21..923c5286 100644
--- a/src/modules/string/index.ts
+++ b/src/modules/string/index.ts
@@ -79,8 +79,6 @@ export type NumericChar =
 export type AlphaChar = LowerAlphaChar | UpperAlphaChar;
 export type AlphaNumericChar = AlphaChar | NumericChar;
 
-const SAMPLE_MAX_LENGTH = 2 ** 20;
-
 /**
  * Module to generate string related entries.
  *
@@ -621,7 +619,7 @@ export class StringModule extends SimpleModuleBase {
   /**
    * Returns a string containing UTF-16 chars between 33 and 125 (`!` to `}`).
    *
-   * @param length Length of the generated string. Max length is `2^20`. Defaults to `10`.
+   * @param length Length of the generated string. Defaults to `10`.
    * @param length.min The minimum number of characters to generate.
    * @param length.max The maximum number of characters to generate.
    *
@@ -647,9 +645,6 @@ export class StringModule extends SimpleModuleBase {
         } = 10
   ): string {
     length = this.faker.helpers.rangeToNumber(length);
-    if (length >= SAMPLE_MAX_LENGTH) {
-      length = SAMPLE_MAX_LENGTH;
-    }
 
     const charCodeOption = {
       min: 33,
diff --git a/test/modules/datatype.spec.ts b/test/modules/datatype.spec.ts
index db676fdc..b4d154f4 100644
--- a/test/modules/datatype.spec.ts
+++ b/test/modules/datatype.spec.ts
@@ -330,12 +330,6 @@ describe('datatype', () => {
           expect(generatedString).toBe('');
           expect(generatedString).toHaveLength(0);
         });
-
-        it('should return string with length of 2^20 if bigger length value is passed', () => {
-          const overMaxValue = Math.pow(2, 28);
-          const generatedString = faker.datatype.string(overMaxValue);
-          expect(generatedString).toHaveLength(Math.pow(2, 20));
-        });
       });
 
       describe('boolean', () => {
diff --git a/test/modules/string.spec.ts b/test/modules/string.spec.ts
index a4f7ecef..e82fa93f 100644
--- a/test/modules/string.spec.ts
+++ b/test/modules/string.spec.ts
@@ -724,12 +724,6 @@ describe('string', () => {
           expect(generatedString).toHaveLength(0);
         });
 
-        it('should return string with length of 2^20 if bigger length value is passed', () => {
-          const overMaxValue = 2 ** 28;
-          const generatedString = faker.string.sample(overMaxValue);
-          expect(generatedString).toHaveLength(2 ** 20);
-        });
-
         it('should return string with a specific length', () => {
           const length = 1337;
           const generatedString = faker.string.sample(length);