aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorST-DDT <[email protected]>2023-10-24 17:28:29 +0200
committerGitHub <[email protected]>2023-10-24 15:28:29 +0000
commit74f6bbd193decda92359c21548c81e68f4550729 (patch)
tree4229589f7c7b41d53e076ddbf05e68df90a3de38
parent79c0f25fd35048e8f6cdf1f375dda8f2f1efb14a (diff)
downloadfaker-74f6bbd193decda92359c21548c81e68f4550729.tar.xz
faker-74f6bbd193decda92359c21548c81e68f4550729.zip
infra(unicorn): no-for-loop (#2490)
-rw-r--r--.eslintrc.js1
-rw-r--r--src/modules/finance/iban.ts4
-rw-r--r--test/docs/versions.spec.ts6
3 files changed, 5 insertions, 6 deletions
diff --git a/.eslintrc.js b/.eslintrc.js
index cd918e3b..eb82b380 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -55,7 +55,6 @@ module.exports = defineConfig({
'unicorn/no-array-callback-reference': 'off',
'unicorn/no-array-reduce': 'off',
'unicorn/no-await-expression-member': 'off',
- 'unicorn/no-for-loop': 'off',
'unicorn/no-negated-condition': 'off',
'unicorn/no-object-as-default-parameter': 'off',
'unicorn/no-useless-switch-case': 'off',
diff --git a/src/modules/finance/iban.ts b/src/modules/finance/iban.ts
index 2eb6fbba..f37bc7f4 100644
--- a/src/modules/finance/iban.ts
+++ b/src/modules/finance/iban.ts
@@ -1398,8 +1398,8 @@ const iban: Iban = {
],
mod97: (digitStr) => {
let m = 0;
- for (let i = 0; i < digitStr.length; i++) {
- m = (m * 10 + +digitStr[i]) % 97;
+ for (const element of digitStr) {
+ m = (m * 10 + +element) % 97;
}
return m;
diff --git a/test/docs/versions.spec.ts b/test/docs/versions.spec.ts
index 5d9efd92..777efcb2 100644
--- a/test/docs/versions.spec.ts
+++ b/test/docs/versions.spec.ts
@@ -38,10 +38,10 @@ describe.runIf(isFakerOrigin())('docs versions', () => {
semver.valid(version)
);
const latestMajorRelease = semver.major(releaseVersions[0].version);
- for (let i = 0; i < releaseVersions.length; i++) {
- const { version, link } = releaseVersions[i];
+ for (const [index, value] of releaseVersions.entries()) {
+ const { version, link } = value;
const oldMajorVersion = semver.major(version);
- expect(oldMajorVersion).toBe(latestMajorRelease - i);
+ expect(oldMajorVersion).toBe(latestMajorRelease - index);
expect(link).toBe(`https://v${oldMajorVersion}.fakerjs.dev/`);
}
});