infra(typescript-eslint): no-confusing-void-expression (#2909)

2 files changed, 8 insertions, 5 deletions

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index a7a7d168..cf0f611c 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -80,6 +80,12 @@ module.exports = defineConfig({
         trailingUnderscore: 'forbid',
       },
     ],
+    '@typescript-eslint/no-confusing-void-expression': [
+      'error',
+      {
+        ignoreArrowShorthand: true,
+      },
+    ],
     '@typescript-eslint/no-inferrable-types': [
       'error',
       { ignoreParameters: true },
@@ -114,10 +120,6 @@ module.exports = defineConfig({
     '@typescript-eslint/unbound-method': 'off',
     '@typescript-eslint/unified-signatures': 'off', // incompatible with our api docs generation
 
-    // TODO @ST-DDT 2023-10-10: The following rules currently conflict with our code.
-    // Each rule should be checked whether it should be enabled/configured and the problems fixed, or stay disabled permanently.
-    '@typescript-eslint/no-confusing-void-expression': 'off',
-
     'jsdoc/require-jsdoc': 'off', // Enabled only for src/**/*.ts
     'jsdoc/require-returns': 'off',
     'jsdoc/sort-tags': [
diff --git a/test/modules/helpers.spec.ts b/test/modules/helpers.spec.ts
index b9b59f22..09f26467 100644
--- a/test/modules/helpers.spec.ts
+++ b/test/modules/helpers.spec.ts
@@ -799,7 +799,8 @@ describe('helpers', () => {
         });
 
         it('should never return the callback result when probability is 0', () => {
-          const actual = faker.helpers.maybe(() => expect.fail(), {
+          const method: () => unknown = expect.fail;
+          const actual = faker.helpers.maybe(method, {
             probability: 0,
           });