aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShinigami <[email protected]>2022-01-30 11:25:23 +0100
committerGitHub <[email protected]>2022-01-30 11:25:23 +0100
commitc1ae64c84bced28c4eadfd464744f8c028b62b17 (patch)
tree0e1d0a846019ccc950c8c2f9c0625748de4a66d9
parentc9329425faef7d90135471e02aa2d083599bdb94 (diff)
downloadfaker-c1ae64c84bced28c4eadfd464744f8c028b62b17.tar.xz
faker-c1ae64c84bced28c4eadfd464744f8c028b62b17.zip
chore: use recommended no-var-requires (#360)
-rw-r--r--.eslintrc.js1
-rw-r--r--test/finance.spec.ts3
-rw-r--r--test/finance_iban.spec.ts3
-rw-r--r--test/locale-imports.spec.ts1
4 files changed, 7 insertions, 1 deletions
diff --git a/.eslintrc.js b/.eslintrc.js
index aef7a33a..72badc74 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -40,7 +40,6 @@ module.exports = defineConfig({
'@typescript-eslint/no-unsafe-call': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-unsafe-return': 'warn',
- '@typescript-eslint/no-var-requires': 'warn',
'@typescript-eslint/restrict-plus-operands': 'warn',
'@typescript-eslint/restrict-template-expressions': [
'error',
diff --git a/test/finance.spec.ts b/test/finance.spec.ts
index e96af64e..724c225e 100644
--- a/test/finance.spec.ts
+++ b/test/finance.spec.ts
@@ -383,7 +383,9 @@ describe('finance', () => {
});
describe('iban()', () => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
const ibanLib = require('../dist/cjs/iban');
+
it('returns a random yet formally correct IBAN number', () => {
const iban =
// @ts-expect-error
@@ -414,6 +416,7 @@ describe('finance', () => {
});
describe('bic()', () => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
const ibanLib = require('../dist/cjs/iban');
it('returns a random yet formally correct BIC number', () => {
const bic = faker.finance.bic();
diff --git a/test/finance_iban.spec.ts b/test/finance_iban.spec.ts
index bdbd6cdc..801ade34 100644
--- a/test/finance_iban.spec.ts
+++ b/test/finance_iban.spec.ts
@@ -101,6 +101,7 @@ describe('finance_iban.js', () => {
// Account Code 16 digits
// Total Length 24 chars
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
const ibanLib = require('../dist/cjs/iban');
it('IBAN for Pakistan is correct', () => {
@@ -165,6 +166,7 @@ describe('finance_iban.js', () => {
// Chiffre d'indicatif national 0
// Numéro de compte bancaire 0519786457841326
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
const ibanLib = require('../dist/cjs/iban');
it('IBAN for Turkish is correct', () => {
@@ -238,6 +240,7 @@ describe('finance_iban.js', () => {
// example IBAN AZ21 NABZ 0000 0000 1370 1000 1944
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
const ibanLib = require('../dist/cjs/iban');
it('IBAN for Azerbaijan is correct', () => {
diff --git a/test/locale-imports.spec.ts b/test/locale-imports.spec.ts
index 1db0f672..4ca8f40d 100644
--- a/test/locale-imports.spec.ts
+++ b/test/locale-imports.spec.ts
@@ -4,6 +4,7 @@ import allLocales from '../src/locales';
describe('locale imports', () => {
for (const locale in allLocales) {
it(`should be possible to directly require('@faker-js/faker/locale/${locale}')`, () => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
const faker = require(`../dist/cjs/locale/${locale}`);
expect(faker).toBeDefined();