More readable gender choosing

1 files changed, 9 insertions, 3 deletions

diff --git a/lib/name.js b/lib/name.js
index 774d44f8..89cb9df2 100644
--- a/lib/name.js
+++ b/lib/name.js
@@ -6,7 +6,9 @@ var _name = {
       if (typeof faker.definitions.name.male_first_name !== "undefined" && typeof faker.definitions.name.female_first_name !== "undefined") {
         // some locale datasets ( like ru ) have first_name split by gender. since the name.first_name field does not exist in these datasets,
         // we must randomly pick a name from either gender array so faker.name.firstName will return the correct locale data ( and not fallback )
-        gender = (typeof gender === 'number') ? gender : faker.random.number(1);
+        if (typeof gender !== 'number') {
+          gender = faker.random.number(1);
+        }
         if (gender === 0) {
           return faker.random.array_element(faker.locales[faker.locale].name.male_first_name)
         } else {
@@ -20,7 +22,9 @@ var _name = {
       if (typeof faker.definitions.name.male_last_name !== "undefined" && typeof faker.definitions.name.female_last_name !== "undefined") {
         // some locale datasets ( like ru ) have last_name split by gender. i have no idea how last names can have genders, but also i do not speak russian
         // see above comment of firstName method
-        gender = (typeof gender === 'number') ? gender : faker.random.number(1);
+        if (typeof gender !== 'number') {
+          gender = faker.random.number(1);
+        }
         if (gender === 0) {
           return faker.random.array_element(faker.locales[faker.locale].name.male_last_name);
         } else {
@@ -35,7 +39,9 @@ var _name = {
         var prefix, suffix;
         // in particular locales first and last names split by gender,
         // thus we keep consistency by passing 0 as male and 1 as female
-        gender = (typeof gender === 'number') ? gender : faker.random.number(1);
+        if (typeof gender !== 'number') {
+          gender = faker.random.number(1);
+        }
         firstName = firstName || faker.name.firstName(gender);
         lastName = lastName || faker.name.lastName(gender);
         switch (r) {