aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorMarak <[email protected]>2020-08-23 22:18:40 -0500
committerGitHub <[email protected]>2020-08-23 22:18:40 -0500
commit3bbac5d10694ea7be4393da54584d3e4f80cd99f (patch)
treefff856f92d134d3263c76c808d2cd1afeeeb57b0 /lib
parenta0a88506e3cdeadd547a58f2e40ff945f3a42f51 (diff)
parentb3fcea2ff8aa03957afbfab2632c72bf020da0e7 (diff)
downloadfaker-3bbac5d10694ea7be4393da54584d3e4f80cd99f.tar.xz
faker-3bbac5d10694ea7be4393da54584d3e4f80cd99f.zip
Merge pull request #684 from blslade-neumont/dev-gender-string
Allowed gender passed to name.firstName(gender) to be a string
Diffstat (limited to 'lib')
-rw-r--r--lib/name.js10
1 files changed, 10 insertions, 0 deletions
diff --git a/lib/name.js b/lib/name.js
index 49b54614..3312b250 100644
--- a/lib/name.js
+++ b/lib/name.js
@@ -15,6 +15,16 @@ function Name (faker) {
if (typeof faker.definitions.name.male_first_name !== "undefined" && typeof faker.definitions.name.female_first_name !== "undefined") {
// some locale datasets ( like ru ) have first_name split by gender. since the name.first_name field does not exist in these datasets,
// we must randomly pick a name from either gender array so faker.name.firstName will return the correct locale data ( and not fallback )
+
+ if(typeof gender === 'string') {
+ if(gender.toLowerCase() === 'male') {
+ gender = 0;
+ }
+ else if(gender.toLowerCase() === 'female') {
+ gender = 1;
+ }
+ }
+
if (typeof gender !== 'number') {
if(typeof faker.definitions.name.first_name === "undefined") {
gender = faker.random.number(1);