aboutsummaryrefslogtreecommitdiff
path: root/src/modules/random
diff options
context:
space:
mode:
authorShinigami <[email protected]>2023-03-16 09:45:48 +0100
committerGitHub <[email protected]>2023-03-16 09:45:48 +0100
commit256631d6be4b2b40ae660a7e9052cde07a3da18c (patch)
tree0356ec41753c439df7bc30de7e2c4403e8f000d1 /src/modules/random
parentf2abf8b49439fc3c6197ecc9a16e212c9e64497a (diff)
downloadfaker-256631d6be4b2b40ae660a7e9052cde07a3da18c.tar.xz
faker-256631d6be4b2b40ae660a7e9052cde07a3da18c.zip
fix(random): prevent infinite do-while (#1938)
Diffstat (limited to 'src/modules/random')
-rw-r--r--src/modules/random/index.ts10
1 files changed, 10 insertions, 0 deletions
diff --git a/src/modules/random/index.ts b/src/modules/random/index.ts
index a2847bbc..b35b7c87 100644
--- a/src/modules/random/index.ts
+++ b/src/modules/random/index.ts
@@ -125,6 +125,8 @@ export class RandomModule {
];
let result: string;
+ let iteration = 0;
+
do {
// randomly pick from the many faker methods that can generate words
const randomWordMethod = this.faker.helpers.arrayElement(wordMethods);
@@ -133,6 +135,14 @@ export class RandomModule {
result = randomWordMethod();
} catch {
// catch missing locale data potentially required by randomWordMethod
+ iteration++;
+
+ if (iteration > 100) {
+ throw new FakerError(
+ 'No matching word data available for the current locale'
+ );
+ }
+
continue;
}
} while (!result || bannedChars.some((char) => result.includes(char)));