aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorST-DDT <[email protected]>2022-12-25 15:30:04 +0100
committerGitHub <[email protected]>2022-12-25 14:30:04 +0000
commitf0d2ffb256e5aefb98d4f38905ef081c8e6af43e (patch)
tree4a4d6d5f3deca0af05910b0c961ea116e5386ceb /src
parentaa77888098add8bc5de5ed8f4f2dbc68aa7e8cef (diff)
downloadfaker-f0d2ffb256e5aefb98d4f38905ef081c8e6af43e.tar.xz
faker-f0d2ffb256e5aefb98d4f38905ef081c8e6af43e.zip
feat(helpers): allow empty string in fake (#1679)
Diffstat (limited to 'src')
-rw-r--r--src/modules/helpers/index.ts12
1 files changed, 2 insertions, 10 deletions
diff --git a/src/modules/helpers/index.ts b/src/modules/helpers/index.ts
index cb4f7680..2ccc311e 100644
--- a/src/modules/helpers/index.ts
+++ b/src/modules/helpers/index.ts
@@ -526,7 +526,7 @@ export class HelpersModule {
*
* It is also NOT possible to use any non-faker methods or plain javascript in such patterns.
*
- * @param pattern The pattern string that will get interpolated. Must not be empty.
+ * @param pattern The pattern string that will get interpolated.
*
* @see faker.helpers.mustache() to use custom functions for resolution.
*
@@ -621,7 +621,7 @@ export class HelpersModule {
*
* It is also NOT possible to use any non-faker methods or plain javascript in such patterns.
*
- * @param pattern The pattern string that will get interpolated. Must not be empty. If an array is passed, a random element will be picked and interpolated.
+ * @param pattern The pattern string that will get interpolated. If an array is passed, a random element will be picked and interpolated.
*
* @see faker.helpers.mustache() to use custom functions for resolution.
*
@@ -645,10 +645,6 @@ export class HelpersModule {
throw new FakerError('Array of pattern strings cannot be empty.');
}
}
- // if incoming str parameter is not provided, return error message
- if (pattern.length === 0) {
- throw new FakerError('Pattern string cannot be empty.');
- }
// find first matching {{ and }}
const start = pattern.search(/{{[a-z]/);
@@ -721,10 +717,6 @@ export class HelpersModule {
const res =
pattern.substring(0, start) + result + pattern.substring(end + 2);
- if (res === '') {
- return '';
- }
-
// return the response recursively until we are done finding all tags
return this.fake(res);
}