diff options
| author | Leyla Jähnig <[email protected]> | 2022-03-21 14:14:57 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2022-03-21 13:14:57 +0000 |
| commit | 486c76e34f22cf1fd66fa2c99e605d52c7077760 (patch) | |
| tree | b31135d4cb91689521d7d357764447c68b1eed03 /test | |
| parent | c51fb1570669284e14915916636de97b7f644e17 (diff) | |
| download | faker-486c76e34f22cf1fd66fa2c99e605d52c7077760.tar.xz faker-486c76e34f22cf1fd66fa2c99e605d52c7077760.zip | |
fix: mersenne rand invalid input argument (#577)
Diffstat (limited to 'test')
| -rw-r--r-- | test/mersenne.spec.ts | 30 |
1 files changed, 8 insertions, 22 deletions
diff --git a/test/mersenne.spec.ts b/test/mersenne.spec.ts index b2201240..e7ca6198 100644 --- a/test/mersenne.spec.ts +++ b/test/mersenne.spec.ts @@ -8,7 +8,7 @@ type SeededRun = { type SeededRunExpectations = { rand: { noArgs: number; - minMax: { max?: number; min?: number; expected?: number; skip?: boolean }[]; + minMax: { max?: number; min?: number; expected?: number }[]; }; }; @@ -21,7 +21,7 @@ const seededRuns: SeededRun[] = [ minMax: [ { max: 100, min: 0, expected: 37 }, { max: undefined, min: 0, expected: 12272 }, - { max: 100, min: undefined, expected: 37, skip: true }, + { max: 100, min: undefined, expected: 37 }, ], }, }, @@ -34,7 +34,7 @@ const seededRuns: SeededRun[] = [ minMax: [ { max: 100, min: 0, expected: 26 }, { max: undefined, min: 0, expected: 8586 }, - { max: 100, min: undefined, expected: 26, skip: true }, + { max: 100, min: undefined, expected: 26 }, ], }, }, @@ -47,7 +47,7 @@ const seededRuns: SeededRun[] = [ minMax: [ { max: 100, min: 0, expected: 92 }, { max: undefined, min: 0, expected: 30425 }, - { max: 100, min: undefined, expected: 92, skip: true }, + { max: 100, min: undefined, expected: 92 }, ], }, }, @@ -60,7 +60,7 @@ const seededRuns: SeededRun[] = [ minMax: [ { max: 100, min: 0, expected: 85 }, { max: undefined, min: 0, expected: 28056 }, - { max: 100, min: undefined, expected: 85, skip: true }, + { max: 100, min: undefined, expected: 85 }, ], }, }, @@ -73,7 +73,7 @@ const seededRuns: SeededRun[] = [ minMax: [ { max: 100, min: 0, expected: 17 }, { max: undefined, min: 0, expected: 5895 }, - { max: 100, min: undefined, expected: 17, skip: true }, + { max: 100, min: undefined, expected: 17 }, ], }, }, @@ -86,7 +86,7 @@ const seededRuns: SeededRun[] = [ minMax: [ { max: 100, min: 0, expected: 89 }, { max: undefined, min: 0, expected: 29217 }, - { max: 100, min: undefined, expected: 89, skip: true }, + { max: 100, min: undefined, expected: 89 }, ], }, }, @@ -122,9 +122,7 @@ describe('mersenne twister', () => { }); } - for (const { min, max, expected } of expectations.rand.minMax.filter( - (x) => !x.skip - )) { + for (const { min, max, expected } of expectations.rand.minMax) { it(`should return ${expected} for rand(${max}, ${min})`, () => { const actual = mersenne.rand(max, min); @@ -132,18 +130,6 @@ describe('mersenne twister', () => { }); } - // TODO @piotrekn 2022-02-13: There is a bug: https://github.com/faker-js/faker/issues/479 - // remove minMax.skip when fixed - for (const { min, max, expected } of expectations.rand.minMax.filter( - (x) => x.skip - )) { - it.todo(`should return ${expected} for rand(${max}, ${min})`, () => { - const actual = mersenne.rand(max, min); - - expect(actual).toEqual(expected); - }); - } - it.todo(`should return 0 for rand(1)`, () => { const actual = mersenne.rand(1); |