feat(number)!: change float default params (#1642)

2 files changed, 26 insertions, 25 deletions

diff --git a/test/__snapshots__/number.spec.ts.snap b/test/__snapshots__/number.spec.ts.snap
index e89a2a0e..14b16521 100644
--- a/test/__snapshots__/number.spec.ts.snap
+++ b/test/__snapshots__/number.spec.ts.snap
@@ -16,13 +16,13 @@ exports[`number > 42 > bigInt > with string value 1`] = `37n`;
 
 exports[`number > 42 > float > with max 1`] = `25.84`;
 
-exports[`number > 42 > float > with min 1`] = `37411.64`;
+exports[`number > 42 > float > with min 1`] = `-25.9`;
 
 exports[`number > 42 > float > with min and max 1`] = `-0.43`;
 
 exports[`number > 42 > float > with min, max and precision 1`] = `-0.4261`;
 
-exports[`number > 42 > float > with plain number 1`] = `37453.636891`;
+exports[`number > 42 > float > with plain number 1`] = `1.5`;
 
 exports[`number > 42 > hex > noArgs 1`] = `"6"`;
 
@@ -52,13 +52,13 @@ exports[`number > 1211 > bigInt > with string value 1`] = `24n`;
 
 exports[`number > 1211 > float > with max 1`] = `64.07`;
 
-exports[`number > 1211 > float > with min 1`] = `92809.09`;
+exports[`number > 1211 > float > with min 1`] = `-2.07`;
 
 exports[`number > 1211 > float > with min and max 1`] = `61.07`;
 
 exports[`number > 1211 > float > with min, max and precision 1`] = `61.0658`;
 
-exports[`number > 1211 > float > with plain number 1`] = `92851.086855`;
+exports[`number > 1211 > float > with plain number 1`] = `3.72`;
 
 exports[`number > 1211 > hex > noArgs 1`] = `"f"`;
 
@@ -88,13 +88,13 @@ exports[`number > 1337 > bigInt > with string value 1`] = `25n`;
 
 exports[`number > 1337 > float > with max 1`] = `18.08`;
 
-exports[`number > 1337 > float > with min 1`] = `26160.2`;
+exports[`number > 1337 > float > with min 1`] = `-30.74`;
 
 exports[`number > 1337 > float > with min and max 1`] = `-12.92`;
 
 exports[`number > 1337 > float > with min, max and precision 1`] = `-12.9153`;
 
-exports[`number > 1337 > float > with plain number 1`] = `26202.205595`;
+exports[`number > 1337 > float > with plain number 1`] = `1.05`;
 
 exports[`number > 1337 > hex > noArgs 1`] = `"4"`;
 
diff --git a/test/number.spec.ts b/test/number.spec.ts
index 5ba1a0a4..7605a513 100644
--- a/test/number.spec.ts
+++ b/test/number.spec.ts
@@ -19,7 +19,7 @@ describe('number', () => {
     });
 
     t.describe('float', (t) => {
-      t.it('with plain number', 0.000001)
+      t.it('with plain number', 4)
         .it('with min', { min: -42 })
         .it('with max', { max: 69 })
         .it('with min and max', { min: -42, max: 69 })
@@ -143,19 +143,20 @@ describe('number', () => {
 
     describe('float', () => {
       it('should return a random float with a default precision of 2 digits after floating point', () => {
-        const number = faker.number.float();
-        expect(number).toBe(Number(number.toFixed(2)));
+        const actual = faker.number.float();
+        expect(actual).toBe(Number(actual.toFixed(2)));
       });
 
-      it('should return a random float given a precision value', () => {
-        const number = faker.number.float(0.001);
-        expect(number).toBe(Number(number.toFixed(3)));
+      it('should return a random float with given max', () => {
+        const actual = faker.number.float(3);
+        expect(actual).toBeGreaterThanOrEqual(0);
+        expect(actual).toBeLessThanOrEqual(3);
       });
 
       it('should return a random number given a max value of 10', () => {
-        const float = faker.number.float({ max: 10 });
-        expect(float).toBeGreaterThanOrEqual(0);
-        expect(float).toBeLessThanOrEqual(10);
+        const actual = faker.number.float({ max: 10 });
+        expect(actual).toBeGreaterThanOrEqual(0);
+        expect(actual).toBeLessThanOrEqual(10);
       });
 
       it('should return 0 given a max value of 0', () => {
@@ -163,16 +164,16 @@ describe('number', () => {
       });
 
       it('should return a random number given a negative number min and max value of 0', () => {
-        const float = faker.number.float({ min: -100, max: 0 });
-        expect(float).toBeGreaterThanOrEqual(-100);
-        expect(float).toBeLessThanOrEqual(0);
+        const actual = faker.number.float({ min: -100, max: 0 });
+        expect(actual).toBeGreaterThanOrEqual(-100);
+        expect(actual).toBeLessThanOrEqual(0);
       });
 
       it('should return a random number between a range', () => {
         for (let i = 0; i < 5; i++) {
-          const randomNumber = faker.number.float({ min: 22, max: 33 });
-          expect(randomNumber).toBeGreaterThanOrEqual(22);
-          expect(randomNumber).toBeLessThanOrEqual(33);
+          const actual = faker.number.float({ min: 22, max: 33 });
+          expect(actual).toBeGreaterThanOrEqual(22);
+          expect(actual).toBeLessThanOrEqual(33);
         }
       });
 
@@ -211,19 +212,19 @@ describe('number', () => {
 
       it('provides numbers with an exact precision', () => {
         for (let i = 0; i < 100; i++) {
-          const number = faker.number.float({
+          const actual = faker.number.float({
             min: 0.5,
             max: 0.99,
             precision: 0.01,
           });
-          expect(number).toBe(Number(number.toFixed(2)));
+          expect(actual).toBe(Number(actual.toFixed(2)));
         }
       });
 
       it('provides number with a precision 0', () => {
-        const float = faker.number.float({ precision: 0 });
+        const actual = faker.number.float({ precision: 0 });
 
-        expect(float).toBe(Math.floor(float));
+        expect(actual).toBe(Math.floor(actual));
       });
 
       it('should not modify the input object', () => {