diff options
| author | Kyle Tsang <[email protected]> | 2021-02-11 21:51:34 -0800 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-02-12 07:51:34 +0200 |
| commit | 02dbd87ffa94ff0d2f5bbc43a13f13033ce01f0b (patch) | |
| tree | df0accc46fae8eff5c0f7874c7a2773ac9ec58c4 /js/src/carousel.js | |
| parent | 0a9d392975d7f77d8a0e10270da7e07aac013614 (diff) | |
| download | bootstrap-02dbd87ffa94ff0d2f5bbc43a13f13033ce01f0b.tar.xz bootstrap-02dbd87ffa94ff0d2f5bbc43a13f13033ce01f0b.zip | |
Fix event handler removal in dropdown/carousel dispose (#33000)
* Fix event handler removal in carousel dispose
* Fix event handler removal in dropdown dispose
* Test event handlers in scrollspy dispose
* Test event handlers in toast dispose
* Test event handlers in tooltip dispose
Co-authored-by: XhmikosR <[email protected]>
Co-authored-by: Rohit Sharma <[email protected]>
Diffstat (limited to 'js/src/carousel.js')
| -rw-r--r-- | js/src/carousel.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/js/src/carousel.js b/js/src/carousel.js index e4c13d593..17814d42d 100644 --- a/js/src/carousel.js +++ b/js/src/carousel.js @@ -216,7 +216,6 @@ class Carousel extends BaseComponent { } dispose() { - super.dispose() EventHandler.off(this._element, EVENT_KEY) this._items = null @@ -226,6 +225,8 @@ class Carousel extends BaseComponent { this._isSliding = null this._activeElement = null this._indicatorsElement = null + + super.dispose() } // Private |