diff options
| author | Johann-S <[email protected]> | 2019-07-23 21:15:00 +0200 |
|---|---|---|
| committer | Johann-S <[email protected]> | 2019-07-24 11:27:35 +0200 |
| commit | fc02932946424e986a72bb7b47044eab815851cb (patch) | |
| tree | 1fb51782942b8cd3d52edaa7146971c5e40a825b /js/src/tab | |
| parent | f4dbffe93adf5c71e16cc07dda24e66ce72d30b5 (diff) | |
| download | bootstrap-fc02932946424e986a72bb7b47044eab815851cb.tar.xz bootstrap-fc02932946424e986a72bb7b47044eab815851cb.zip | |
use get selector from element only when needed
Diffstat (limited to 'js/src/tab')
| -rw-r--r-- | js/src/tab/tab.js | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/js/src/tab/tab.js b/js/src/tab/tab.js index e882ff1d2..c9f4869ef 100644 --- a/js/src/tab/tab.js +++ b/js/src/tab/tab.js @@ -9,7 +9,7 @@ import { jQuery as $, TRANSITION_END, emulateTransitionEnd, - getSelectorFromElement, + getElementFromSelector, getTransitionDurationFromElement, makeArray, reflow @@ -85,10 +85,9 @@ class Tab { return } - let target let previous + const target = getElementFromSelector(this._element) const listElement = SelectorEngine.closest(this._element, Selector.NAV_LIST_GROUP) - const selector = getSelectorFromElement(this._element) if (listElement) { const itemSelector = listElement.nodeName === 'UL' || listElement.nodeName === 'OL' ? Selector.ACTIVE_UL : Selector.ACTIVE @@ -113,10 +112,6 @@ class Tab { return } - if (selector) { - target = SelectorEngine.findOne(selector) - } - this._activate( this._element, listElement |